Minor fixes for integration tests

[fridrich]

This fixes integration tests 1) with openSUSE OpenJDK versions and 2) one test where error message has additional metadata after the url).

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[fridrich]

BTW, there are two files mng-8572-di-type-handler/test/settings.xml and mng-3259/settings.xml that define bogus <localRepository>, but those two files are never actually passed via --settings in their respective tests. They are dead weight and I only noticed them because I was grepping for the "proper" way to fix the stray repository problem in mng-3955 test. I did not remove them because they don't harm anything, but just mentioning it here.

[fridrich]

This would be clearly back-portable to 4.0.x, is there a way for you to do it, or should I eventually create a new PR for that?

[elharo]

Please file an issue to remove the dead files you found or just send a PR. Thanks.

[fridrich]

Please file an issue to remove the dead files you found or just send a PR. Thanks.

#12887

[elharo]

It is weird that this one is failing just on your system. I need to dig into it in more detail,. It could be that the change is not where you've made the change. It might be that a different line is omitted from your output completely and this asks the verifier to check a different line. I want to be cautious about this one until we understand it fully.

[fridrich]

log_host.txt

[fridrich]

So, the difference is that in the container, there is a cached failure of resolution and in the host machine there is a actual re-download attempt. There are now two possibilities, either we leave my fix, or add verifier.addCliArgument("-U"); to override the caching for this test. And then we can leave that string untouched

I run it in the container with the "-U" and it passed with the original string. Tell me what is preferable.

[fridrich]

It boils to the difference between messages in the situation when things are cached and when they are not:
-[ERROR] Non-resolvable parent POM: The following artifacts could not be resolved: org.apache:apache:pom:33 (absent): org.apache:apache:pom:33 was not found in https://repo1.maven.org during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced (remote repositories: central (https://repo1.maven.org, default, releases)) and parent could not be found in reactor @ org.apache.maven.its.it0043:maven-it-it0043:1.0-SNAPSHOT, file:///home/fstrba/devel-cvs/fridrich-maven/its/core-it-suite/target/test-classes/mng-8181-central-repo/pom.xml, line 23, column 3: One or more requests failed -org.apache.maven.api.services.model.ModelResolverException: The following artifacts could not be resolved: org.apache:apache:pom:33 (absent): org.apache:apache:pom:33 was not found in https://repo1.maven.org during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced (remote repositories: central (https://repo1.maven.org, default, releases)) +[ERROR] Non-resolvable parent POM: The following artifacts could not be resolved: org.apache:apache:pom:33 (absent): Could not find artifact org.apache:apache:pom:33 in central (https://repo1.maven.org) (remote repositories: central (https://repo1.maven.org, default, releases)) and parent could not be found in reactor @ org.apache.maven.its.it0043:maven-it-it0043:1.0-SNAPSHOT, file:///home/fstrba/devel-cvs/fridrich-maven/its/core-it-suite/target/test-classes/mng-8181-central-repo/pom.xml, line 23, column 3: One or more requests failed +org.apache.maven.api.services.model.ModelResolverException: The following artifacts could not be resolved: org.apache:apache:pom:33 (absent): Could not find artifact org.apache:apache:pom:33 in central (https://repo1.maven.org) (remote repositories: central (https://repo1.maven.org, default, releases))

[fridrich]

I gave it a thought and the -U option is exactly maven's way to deal with caching when one wants to redownload anyway. This then only happens in caching setting and if the tests are running twice without cleaning. With this one, one can run the tests as much as one wants and they will still do what they have to do.

[elharo]

sounds good, thanks for the investigation

[github-actions]

@elharo Please assign appropriate label to PR according to the type of change.