Skip to content

Minor fixes for integration tests #12871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elharo merged 4 commits into from
Aug 28, 2026
Merged

Minor fixes for integration tests #12871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57d2713
Don't assume -Ddoclint default
fridrich Aug 27, 2026
b774a3a
Force download even when the system is set to cache central downloads
fridrich Aug 27, 2026
406f6c5
Don't leave stray repository inside the sources
fridrich Aug 27, 2026
4a71205
Don't fail a subsequent run with FileAlreadyExistsException
fridrich Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions its/core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public static void assertCanonicalFileEquals(Path expected, Path actual) throws
}

public static void createFile(Path path) throws IOException {
Files.deleteIfExists(path);
Files.createFile(path);
}

Expand Down
1 change: 1 addition & 0 deletions its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3955EffectiveSettingsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public void testitMNG3955() throws Exception {
Verifier verifier = newVerifier(testDir);
Path localRepo = verifier.getLocalRepository();
verifier.setAutoclean(false);
verifier.deleteDirectory("target");
verifier.addCliArgument("-Dmaven.repo.local.tail=" + localRepo);
verifier.addCliArgument("--settings");
verifier.addCliArgument("settings.xml");
Expand Down
1 change: 1 addition & 0 deletions ...it-suite/src/test/java/org/apache/maven/it/MavenITmng7967ArtifactHandlerLanguageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ void javadocIsExecutedAndFailed() throws Exception {
Verifier verifier = newVerifier(testDir);
verifier.deleteDirectory("target");
verifier.addCliArgument("org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:jar");
verifier.addCliArgument("-Ddoclint=all");

boolean invocationFailed = false;
// whatever outcome we do not fail here, but later
Expand Down
1 change: 1 addition & 0 deletions its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng8181CentralRepoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public void testitModel() throws Exception {
verifier.addCliArgument("-Dmaven.repo.local.tail=target/null");
// note: intentionally bad URL, we just want tu ensure that this bad URL is used
verifier.addCliArgument("-Dmaven.repo.central=https://repo1.maven.org");
verifier.addCliArgument("-U");
verifier.addCliArgument("validate");
verifier.setHandleLocalRepoTail(false); // we want isolation to have Maven fail due bad URL
assertThrows(VerificationException.class, verifier::execute);
Expand Down
2 changes: 1 addition & 1 deletion its/core-it-suite/src/test/resources/mng-3955/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ under the License.
-->

<settings xmlns='http://maven.apache.org/SETTINGS/1.0.0'>
<localRepository>mng-3955</localRepository>
<localRepository>target/mng-3955</localRepository>
<offline>false</offline>
<interactiveMode>true</interactiveMode>
</settings>
Loading