fix: reconstruct the fork file network instead of checking out fork code - #134
Merged
Conversation
Reverts #133, which checked out the fork to give Codecov a file list. actions/checkout refuses fork checkouts from workflow_run, so the step failed and job-level continue-on-error skipped the upload entirely. The fork build now records git ls-files -z with its coverage, and the privileged job rebuilds those paths as zero-byte files in a scratch repo.
ernst-dev
requested review from
georgylobko
and
a lite review from Copilot
and removed request for
a team
September 1, 2026 10:54
Pinning to lcov.info alone would have silently stopped build-tools, which emits clover.xml. The CLI warns and skips explicitly named files that are absent, so listing both is safe for repositories that emit only one.
…fact A fork that tracks its coverage directory would have coverage/lcov.info in its file listing, and reconstruction would truncate the real report to zero bytes before the upload, publishing 0% coverage. Skip those paths; hostile ones are still rejected because validation runs first.
dirname parses a leading dash as an option, so a tracked file like -foo aborted the step under set -e and skipped the upload.
Copilot stopped reviewing on behalf of
ernst-dev due to an error
September 1, 2026 12:52
ernst-dev
enabled auto-merge (squash)
September 1, 2026 12:55
pan-kot
approved these changes
Sep 1, 2026
ernst-dev
added a commit
that referenced
this pull request
Sep 1, 2026
codecov.sh sets IFS=, before splitting CC_FILES, so the newline block scalar from #134 became one --file argument with an embedded newline and uploaded nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #133 and replaces it with a path-only reconstruction.
Codecov resolves report paths against the repository file list. #133 supplied that by checking out the fork, which
actions/checkoutrefuses fromworkflow_run; the step failed and job-levelcontinue-on-errorthen silently skipped the upload entirely.Now the fork build records
git ls-files -znext to its coverage, and the privileged job rebuilds those paths as zero-byte files in a scratch repo — no checkout, no fork content, listing validated and failing closed. Placeholders are sufficient because Codecov never receives source: the payload is a path list plus the report, andlcov.infoalready carries the line, branch and function data.Search is disabled and the upload names
coverage/lcov.info(components) andcoverage/clover.xml(build-tools); the CLI warns and skips whichever is absent.build-toolsuploads runner-absolute paths, so onlycomponentsis a clean single-variable test of the path fix — coverage with absolute paths beats no coverage. cloudscape-design/components#4947 is the test case.