Delete repetition detection outright (CL-6995) - #612
Merged
Conversation
TheGreatAxios
enabled auto-merge (squash)
August 24, 2026 08:50
Removes the streamed-text loop detector (repetition.ts + period-detection.ts), the director's tool-fingerprint period/cycle thrash check and turns-since-user-message backstop, and the leaf no-progress (identical-tool-call) counter. Dead-by-consequence cleanup: the compaction summarizer no longer filters assistant turns for repetition before excerpting, and the TUI stream-buffer throttle that only existed to pace the deleted character-loop check is gone (the independent cross-cycle fingerprint stall recovery in turn-state.ts is untouched). Kept: provider stream error handling, connection retry/backoff, the turn budget stop, and the director's soft tool-only check-in nudge (toolOnlyTurnNudgeAt) — a turn-count nudge, not repetition detection.
TheGreatAxios
force-pushed
the
cl-6995-delete-repetition-detection-v2
branch
from
August 24, 2026 08:52
aa2dcd6 to
664438f
Compare
This was referenced Aug 24, 2026
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
Removes the streamed-text loop detector (repetition.ts + period-detection.ts), the director's tool-fingerprint period/cycle thrash check and turns-since-user-message backstop, and the leaf no-progress (identical-tool-call) counter. Dead-by-consequence cleanup: the compaction summarizer no longer filters assistant turns for repetition before excerpting, and the TUI stream-buffer throttle that only existed to pace the deleted character-loop check is gone (the independent cross-cycle fingerprint stall recovery in turn-state.ts is untouched). Kept: provider stream error handling, connection retry/backoff, the turn budget stop, and the director's soft tool-only check-in nudge (toolOnlyTurnNudgeAt) — a turn-count nudge, not repetition detection.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
Removes the streamed-text loop detector (repetition.ts + period-detection.ts), the director's tool-fingerprint period/cycle thrash check and turns-since-user-message backstop, and the leaf no-progress (identical-tool-call) counter. Dead-by-consequence cleanup: the compaction summarizer no longer filters assistant turns for repetition before excerpting, and the TUI stream-buffer throttle that only existed to pace the deleted character-loop check is gone (the independent cross-cycle fingerprint stall recovery in turn-state.ts is untouched). Kept: provider stream error handling, connection retry/backoff, the turn budget stop, and the director's soft tool-only check-in nudge (toolOnlyTurnNudgeAt) — a turn-count nudge, not repetition detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/subagent/repetition.tsandsrc/util/period-detection.tsoutright (streamed-text loop detector, tool-fingerprint period/cycle thrash check).TURNS_SINCE_USER_MESSAGE_BACKSTOP,MAX_LEAF_PROGRESS_BACKSTOP_RESETS) and the leaf no-progress (identical-tool-call) counter — the latter re-checked and still present on main, so removed here per scope.turn-state.tsthat only existed to pace the deleted character-loop check is gone.consecutiveMatchingCyclescross-cycle stall recovery is untouched (independent mechanism, out of scope).{report, stopReason?}shape rather than rebasing PR Delete repetition/thrash/backstop detection outright #609, since main had moved under it.Transport/policy line kept
toolOnlyTurnNudgeAt) — a turn-count nudge, not repetition detection — untouched.Test plan
bun run check(lint + typecheck + build + test) green — 5350 pass, 0 fail.scripts/verify-corbits-only-scope.shpasses (no vendor/ changes).