fix(performance): cap complexity-regression reads to use corpus reader - #131
Merged
alxxjohn merged 1 commit intoAug 18, 2026
Merged
Conversation
alxxjohn
deleted the
alexj/propose-fix-for-performance-rule-vulnerability
branch
August 18, 2026 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
performance.complexity-regressionrule read changed.gopaths withos.ReadFile(...)which bypassed the repository's capped reader and could follow attacker-controlled symlinks, enabling scan hangs or unbounded memory use.Description
env.ReadTargetFilein the early guard so the rule only runs when the safe reader is available by checkingenv.ReadTargetFilein addition toenv.ReadBaseFileand diff mode.os.ReadFile(filepath.Join(target.Path, ...))call withenv.ReadTargetFile(target, rel)to reuse the shared, capped file-corpus reader that enforcesmaxScanFileBytes.env.ReadBaseFile(target, rel)before reading the head file so newly added files (which have no base) are skipped without reading attacker-controlled worktree targets.Files changed:
internal/codeguard/checks/performance/performance_complexity_regression.goTesting
gofmt -w internal/codeguard/checks/performance/performance_complexity_regression.goto format the change andgit diff --checkto validate local diffs; both succeeded.go test ./tests/checks -run 'TestComplexityRegression'and observed success.go test ./internal/codeguard/checks/performance ./internal/codeguard/runner/support ./tests/checksand observed success.Codex Task