Skip to content

fix(performance): cap complexity-regression reads to use corpus reader #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxxjohn merged 1 commit into from
Aug 18, 2026
Merged

fix(performance): cap complexity-regression reads to use corpus reader #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions internal/codeguard/checks/performance/performance_complexity_regression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import (
"fmt"
"go/ast"
"go/token"
"os"
"path/filepath"
"strings"

"github.com/devr-tools/codeguard/internal/codeguard/checks/support"
Expand All @@ -24,7 +22,7 @@ func complexityRegressionFindings(env support.Context, target core.TargetConfig)
if !toggleEnabled(env.Config.Checks.PerformanceRules.DetectComplexityRegression) {
return nil
}
if env.Mode != core.ScanModeDiff || env.DiffScope == nil || env.ReadBaseFile == nil {
if env.Mode != core.ScanModeDiff || env.DiffScope == nil || env.ReadBaseFile == nil || env.ReadTargetFile == nil {
return nil
}
switch support.NormalizedLanguage(target.Language) {
Expand All @@ -47,19 +45,19 @@ func complexityRegressionFindings(env support.Context, target core.TargetConfig)
}

func complexityRegressionFileFindings(env support.Context, target core.TargetConfig, rel string, changed core.ChangedLineRanges) []core.Finding {
headData, err := os.ReadFile(filepath.Join(target.Path, filepath.FromSlash(rel))) //nolint:gosec // target path from config + rel path from the scan's own git diff
baseData, err := env.ReadBaseFile(target, rel)
if err != nil {
// Deleted (or unreadable) file: nothing on the head side to regress.
// Added file: every function is new, so there is no base to compare.
return nil
}
headFset, headFile, err := support.ParseGoSource(env, rel, headData)
headData, err := env.ReadTargetFile(target, rel)
if err != nil {
// Unparseable Go is the quality section's problem (quality.parse-error).
// Deleted, unreadable, or oversized file: nothing safe to compare.
return nil
}
baseData, err := env.ReadBaseFile(target, rel)
headFset, headFile, err := support.ParseGoSource(env, rel, headData)
if err != nil {
// Added file: every function is new, so there is no base to compare.
// Unparseable Go is the quality section's problem (quality.parse-error).
return nil
}
baseDepths, err := baseFunctionLoopDepths(rel, baseData)
Expand Down
Loading