fix: retry _gh_post/_gh_delete once on transient network failure - #588
Open
essentialbit wants to merge 2 commits into
Open
fix: retry _gh_post/_gh_delete once on transient network failure#588essentialbit wants to merge 2 commits into
essentialbit wants to merge 2 commits into
Conversation
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_gh_getincommunity.pyalready retries once on a transient network error/5xx (PR fix: retry _gh_get once on transient network failure before giving up #584, open)._gh_post/_gh_deletehad no such retry — a transient failure there silently drops the write (comment/label) instead of the ambiguous-pagination-truncation failure mode fix: retry _gh_get once on transient network failure before giving up #584 targets, but the same root fix applies.run_debate_cycle()generated a stance for issue 8-K Item 3.01 (Delisting Notice) miscategorized as routine #563 (cost a real LLM call), then_gh_postfor the comment and label both failed with 503 and were silently dropped — no retry, no error surfaced, issue 8-K Item 3.01 (Delisting Notice) miscategorized as routine #563 still shows no new stance comment._gh_postand_gh_delete.Test plan
python3 -c "from main import *; print('Import OK')"passestests/dir in this repo (confirmed, same as always)requests, deleted after): transient-then-recover and persistent-failure-bounds-at-2-attempts for both_gh_postand_gh_delete, plus 404-treated-as-success-no-spurious-retry for_gh_delete— all passSelf-directed tooling / infra hardening — no
feature_backlogproposal, no consensus/outcome-recording needed (same precedent class as #584 itself).🤖 Generated with Claude Code