Skip to content

revert the AGP version pin #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatfiredev merged 1 commit into from
Aug 27, 2026
Merged

revert the AGP version pin #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,9 @@ fun notFromFirebase(candidate: ModuleComponentIdentifier): Boolean {
return candidate.group != "com.google.firebase"
}

// TODO(b/522845800): remove this once the bug with AGP 9.3.x and lint has been fixed
fun isBuggyAGP(candidate: ModuleComponentIdentifier): Boolean {
// Skip versions <= 9.3.1
val candidateName = candidate.toString().lowercase()
return (candidateName.contains("com.android.application") ||
candidateName.contains("com.android.library")) &&
candidate.version.replace(".", "").toInt() <= 931
}

tasks.withType<DependencyUpdatesTask> {
rejectVersionIf {
(isNonStable(candidate) && notFromFirebase(candidate)) || isBlockListed(candidate) ||
isBuggyAGP(candidate)
(isNonStable(candidate) && notFromFirebase(candidate)) || isBlockListed(candidate)
}
}

Expand Down
Loading