fix(connections): make google and google drive browser logins not tokens

[Rchari1]

Summary

The connectors tab rendered Google and Google Drive with a token field (picker) and token-only in BUILT_IN_CATALOG, but the product contract is browser OAuth. The status card already advertises auth_methods=["browser"] and shows a "Sign in with browser" button — the picker and catalog were the mismatch.

This PR aligns the whole path to browser logins:

• Server (packages/opencode/src/server/amicode/connections.ts): BUILT_IN_CATALOG for google / google-drive goes token-only → browser, and the ConnectionEntry.authShape union is extended to include browser so the catalog endpoint reflects the real flow.
• UI model (packages/ui/src/amicode/connections.ts): ConnectionFormKind extended with browser; connectionFormKind() now returns browser for those two IDs (instead of token-only); methodEntryKind updated so the auth chooser resolves browser → none correctly.
• Picker (packages/ui/src/amicode/connection-picker.tsx): the Add-flow previously rendered only a token form for every built-in. It now branches on authShape: browser entries show a "Sign in with browser" button (with a Browser badge in the list) and no token field; token entries keep the token form. Accepts optional onStartBrowser.
• Tab wiring (packages/ui/src/amicode/connections-tab.tsx): both picker instances now pass onStartBrowser → startAuthPayload(…, "browser") → props.onStartAuth, so the existing browser OAuth start path is used.

What this fixes

• Fixes the connectors-tab token-vs-browser mismatch reported as "google and google drive connectors should be browser logins not tokens".
• Picker no longer asks for a Google token; it triggers the browser flow.
• Server catalog and UI form-kind are consistent (browser end-to-end).

Follow-up

Server OAuth POST /amicode/connections/start / callback implementation is the next step once the Google Cloud OAuth client is available. This UI change is forward-compatible.

Testing

• Manual: Add connection picker now shows Google / Google Drive with a "Browser" badge and a "Sign in with browser" button instead of a token input; existing Slack/GitHub/Linear still show token form.

Summary by CodeRabbit

• New Features
  • Added browser-based sign-in for Google and Google Drive connections.
  • Updated connection pickers to identify and launch browser authentication.
  • Preserved token-based sign-in for Slack, GitHub, and Linear connections.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 21664151-d13c-45c2-86cd-37cbcfe49d4e

📥 Commits

Reviewing files that changed from the base of the PR and between 4c28e8b and bb027ac.

📒 Files selected for processing (4)

• packages/opencode/src/server/amicode/connections.ts
• packages/ui/src/amicode/connection-picker.tsx
• packages/ui/src/amicode/connections-tab.tsx
• packages/ui/src/amicode/connections.ts

---

📝 Walkthrough

Walkthrough

The connection catalog now supports browser authentication. Google and Google Drive use browser sign-in in the connection picker, and both connections-tab flows dispatch browser authentication payloads.

Changes

Browser authentication

Layer / File(s)	Summary
Catalog and form routing packages/opencode/src/server/amicode/connections.ts, packages/ui/src/amicode/connections.ts	The connection contracts and form-kind routing now support "browser". Google and Google Drive use this form kind.
Browser sign-in picker flow packages/ui/src/amicode/connection-picker.tsx	ConnectionPicker labels browser-auth entries and renders browser sign-in controls. Other entries retain token submission.
Authentication start wiring packages/ui/src/amicode/connections-tab.tsx	Both picker instances create browser authentication payloads, call onStartAuth, and close the picker.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant ConnectionPicker
  participant ConnectionsTab
  participant onStartAuth
  User->>ConnectionPicker: Select browser-auth connection
  ConnectionPicker->>ConnectionsTab: Invoke onStartBrowser(id)
  ConnectionsTab->>onStartAuth: Dispatch browser authentication payload
  ConnectionsTab->>ConnectionPicker: Close picker

Loading

Possibly related PRs

• harmoniqs/opencode#194: Introduces the connection catalog and picker flows extended by this change.
• harmoniqs/opencode#197: Adds related Google and Google Drive browser-auth support.

Suggested reviewers: kateebonner

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/google-browser-login

---

_{Comment @coderabbitai help to get the list of available commands.}