Validate the data on every pull request, and fix everything it found - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the rmmz-plugins build from je-can-code/rmmz-plugins#121, and gives the data a validator that runs on every pull request.
Validation
bun run validatechecks the seams between the three things that writechef-adventure/data: every data file parses, no backup is committed,js/plugins/j/is exactly one rmmz-plugins build with nothing stale beside it, every id a notetag or a plugin config names is a real row, and every notetag matches a pattern some plugin declares. What each tag means comes from themanifest.jsonthe build now writes beside the plugins..github/workflows/validate.ymlruns it on every pull request and every push to main, afterbun run validate:selftest, which plants each kind of bug in memory and fails unless every one is caught.package.jsonis new, as the home of those two scripts, andCLAUDE.mddocuments both.Fixes it found
js/plugins/j/, a stale source map, andClasses.old.json..gitignoreignores*.old.json,*.backup*and*.bak*.\itemcodes.hrctohcron the Life Cost states,jabsRoletoaiRoleon the Guardian and Sentinel maps, anddergrees,tpPercandswitchChoiceCondition.juiceRepeatMotiontojuiceRepeatCount,animationOnSelftoselfAnimationId, andtargetingtotargeted.<damagePerc:5>from 18 maps. It went with J-CAMods' floor damage, and regions replace it.<tickSpeedTypePercent:[burn, 100]>. Untouchable grants 1000% evasion and magic evasion. Smother drains throughmpFormulaandtpFormula. Careless lowers crit reduction, which the plugins now allow. Skeletor and Kapn Kappa are careful. Equilibrium's growth tag namessar.docs/database-decode-cheatsheet.mdcalls ex-parameter 1 Phys Evade, not Parry Extend.Growth
cdmGrowthPlusreads 1.5, Blind lowers hit with<hitBuffRate:[-10]>, and Deathless Fury's pdr and mdr buffs read -50, all three having been written as fractions.Plugins
Unrelated, from a sibling thread
MapInfos.jsonandSystem.jsoncarry editor-save noise.