Skip to content

test: stabilize concurrent JsVar broadcast assertion - #410

Merged
linkdata merged 1 commit into
mainfrom
fix/jsvar-concurrent-batch-test
Sep 25, 2026
Merged

linkdata merged 1 commit into
mainfrom
fix/jsvar-concurrent-batch-test

Conversation

@linkdata

Copy link
Copy Markdown
Owner

Summary

  • Run the concurrent JsVar broadcast test in testing/synctest so both writes reach the same batch before the update tick.
  • Replace the wall-clock wait with a channel handshake and a virtual tick; require exactly one final Set and the matching Go value.

The old assertion could read a valid intermediate Set when the writes straddled two ticks.

Verification

  • Focused race test: 1,000 runs
  • Full JAWS_REQUIRE_NODE=1 go test -race -count=1 ./... and non-race suite
  • go vet, staticcheck, golangci-lint, gosec, gofumpt, go build

Fixes #408

@linkdata
linkdata merged commit d23f909 into main Sep 25, 2026
7 checks passed
@linkdata
linkdata deleted the fix/jsvar-concurrent-batch-test branch September 25, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate intermittent JsVar concurrent broadcast test failure

1 participant