Skip to content

test: stabilize concurrent JsVar broadcast assertion #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linkdata merged 1 commit into from
Sep 25, 2026
Merged

test: stabilize concurrent JsVar broadcast assertion #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 37 additions & 59 deletions lib/ui/jsvar_order_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"io"
"sync"
"testing"
"testing/synctest"
"time"

"github.com/linkdata/jaws"
Expand Down Expand Up @@ -106,73 +107,50 @@ func readJsVarSet(t *testing.T, tr *jawstest.TestRequest) (data string) {
}

func TestJsVarConcurrentBroadcastsKeepLatestMutation(t *testing.T) {
jsvar, elem, tr := newOrderedJsVar(t)

firstEntered := make(chan struct{})
releaseFirst := make(chan struct{})
firstErr := make(chan error, 1)
go func() {
firstErr <- jsvar.JawsSetPath(elem, "value", orderedMarshalValue{
Text: "first",
Entered: firstEntered,
Release: releaseFirst,
})
}()
select {
case <-t.Context().Done():
synctest.Test(t, func(t *testing.T) {
jsvar, elem, tr := newOrderedJsVar(t)

firstEntered := make(chan struct{})
releaseFirst := make(chan struct{})
setErr := make(chan error, 2)
go func() {
setErr <- jsvar.JawsSetPath(elem, "value", orderedMarshalValue{
Text: "first",
Entered: firstEntered,
Release: releaseFirst,
})
}()
<-firstEntered

secondStarted := make(chan struct{})
go func() {
close(secondStarted)
setErr <- jsvar.JawsSetPath(elem, "value", orderedMarshalValue{Text: "second"})
}()
<-secondStarted
close(releaseFirst)
t.Fatal("timed out waiting for the first value to enter JSON marshaling")
case <-firstEntered:
}

secondErr := make(chan error, 1)
go func() {
secondErr <- jsvar.JawsSetPath(elem, "value", orderedMarshalValue{Text: "second"})
}()
for range 2 {
if err := <-setErr; err != nil {
t.Fatal(err)
}
}

secondCompleted := false
timer := time.NewTimer(100 * time.Millisecond)
select {
case err := <-secondErr:
if err != nil {
t.Fatal(err)
synctest.Wait()
time.Sleep(jaws.DefaultUpdateInterval + time.Millisecond)
synctest.Wait()
if got := readJsVarSet(t, tr); got != `value="second"` {
t.Fatalf("broadcast = %q, want latest mutation", got)
}
secondCompleted = true
case <-timer.C:
}
if !timer.Stop() {
select {
case <-timer.C:
case msg := <-tr.OutCh:
t.Fatalf("unexpected extra broadcast: %#v", msg)
default:
}
}
close(releaseFirst)

select {
case <-t.Context().Done():
t.Fatal("timed out waiting for the first JsVar set")
case err := <-firstErr:
if err != nil {
t.Fatal(err)
if current := jsvar.JawsGet(elem).Value; current != "second" {
t.Fatalf("bound value = %q, want latest mutation %q", current, "second")
}
}
if !secondCompleted {
select {
case <-t.Context().Done():
t.Fatal("timed out waiting for the second JsVar set")
case err := <-secondErr:
if err != nil {
t.Fatal(err)
}
}
}

if got := readJsVarSet(t, tr); got != `value="second"` {
t.Fatalf("broadcast = %q, want latest mutation", got)
}
if current := jsvar.JawsGet(elem).Value; current != "second" {
t.Fatalf("bound value = %q, want latest mutation %q", current, "second")
}
})
}

func TestJsVarMarshalErrorReleasesSetterOrder(t *testing.T) {
Expand Down
Loading