🐛 Remove QCO/QTensor dependency cycles - #2352
Merged
Merged
Conversation
Declare the dependencies between QCO, QTensor, and its utilities so CMake repeats their static archives for standalone QIR consumers. Add the public QCO links after add_mlir_dialect_library to avoid LLVM’s cyclic object-library build dependencies. Generated headers still precede compilation through mlir-headers. Remove the runtime-only QTensor link. Assisted-by: GPT-5.6 via Codex
Apply the same build-tree RPATH policy as the other test targets. The LLVM IR test programs must find shared MQT Core libraries before install. Assisted-by: GPT-5.6 via Codex
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Register QTensor scalarization through the native dialect hook and move its regression tests to the QTensor suite. Remove the unused IR-to-utils edge and restore ordinary one-way library dependencies. Assisted-by: Codex
12 tasks
burgholzer
enabled auto-merge (squash)
September 3, 2026 22:02
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Remove the QCO/QTensor library dependency cycles instead of relying on static archive repetition or bypassing LLVM's target ordering.
qco.ifscalarization pattern into QTensor's native dialect-wide canonicalization hook. QCO IR no longer includes or links QTensor.This PR is based on
mainand is independent of #2336. It preserves the scalarization algorithm and compiler pipeline without adding a pass, library, or interface. No standalone changelog or upgrade entry is needed for this internal fix to unreleased compiler code.Validation
BUILD_MQT_CORE_SHARED_LIBS=ON: all 72 QIR runtime tests passed.uvx nox -s cpp-lint,uvx nox -s lint, andgit diff --checkpassed.An additional global
BUILD_SHARED_LIBS=ONconfiguration probe is blocked by QDMI install-export declarations forMLIRQCODDFunctionalityandMQTCompilerPipeline. That packaging issue is outside this change.Codex assisted with dependency analysis, code relocation, and local validation.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).