stream: reject primitive values in ReadableStream.from

[standard-Chan]

This updates ReadableStream.from() to reject primitive values before looking up iterator methods.

WHATWG Streams changed ReadableStream.from() to use the Web IDL async_sequence<T> type (added in whatwg#1372)

That makes string inputs invalid because Web IDL sequence conversion requires non-object values to throw a TypeError:
spec es-sequence

1. If V is not an Object, throw a TypeError.

WPT added coverage for this behavior here: web-platform-tests/wpt#59594

This change aligns Node.js with that WPT expectation and removes the corresponding expected failure for test (ReadableStream.from throws on invalid iterables; specifically a string)

Tests:

$ node test/wpt/test-streams.js readable-streams/from.any.js

Files: 2/2 ran, 2 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes
Subtests: 100 passed, 0 skipped, 0 expected failures, 0 unexpected failures, 0 unexpected passes

$ tools/test.py wpt/test-streams

[00:05|% 100|+   1|-   0]: Done

All tests passed.

[nodejs-github-bot]

Review requested:

• @nodejs/web-standards

[MattiasBuelens]

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

[standard-Chan]

Thanks for your contribution, but I'm afraid this is a duplicate... 😥

This is issue #64288, and there's already a draft PR open for it that is nearly identical to this PR: #64465.

Thanks for letting me know. I missed them.

I'll close this PR. Thanks for reviewing it!

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (4605cf5) to head (d41a8e0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65676      +/-   ##
==========================================
+ Coverage   90.06%   90.11%   +0.05%     
==========================================
  Files         754      754              
  Lines      255759   256313     +554     
  Branches    48327    48515     +188     
==========================================
+ Hits       230350   230988     +638     
+ Misses      16534    16450      -84     
  Partials     8875     8875              

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	90.58% <40.00%> (+3.25%)	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.