Skip to content

stream: reject primitive values in ReadableStream.from #65676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
standard-Chan wants to merge 1 commit into from
+5 −7
Closed

stream: reject primitive values in ReadableStream.from #65676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,11 @@ function createReadableStreamState() {
}

function readableStreamFromIterable(iterable) {
if (iterable === null ||
(typeof iterable !== 'object' && typeof iterable !== 'function')) {
throw new ERR_ARG_NOT_ITERABLE(iterable);
}

let stream;
const iteratorGetter = iterable[SymbolAsyncIterator] ?? iterable[SymbolIterator];
if (iteratorGetter == null || typeof iteratorGetter !== 'function') {
Expand Down
7 changes: 0 additions & 7 deletions test/wpt/status/streams.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@
"readable-streams/cross-realm-crash.window.js": {
"skip": "Browser-specific test"
},
"readable-streams/from.any.js": {
"fail": {
"expected": [
"ReadableStream.from throws on invalid iterables; specifically a string"
]
}
},
"readable-streams/owning-type-message-port.tentative.any.js": {
"fail": {
"note": "Readable streams with type owning are not yet supported",
Expand Down
Loading