[scanner] fix: add PXE netboot installer support - #25
Closed
kubestellar-hive[bot] wants to merge 1 commit into
Closed
kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Aug 27, 2026
Merged
hanthor
suggested changes
Sep 2, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
The implementation itself is sound and was previously approved by a human maintainer with CI green at the time — but mergeable_state is now dirty: main has since independently merged the PXE-artifact-export portion (kernel/initrd + SHA256SUMS lines) that this PR also adds, so it now textually conflicts. Needs a rebase before it can land. See also #22/#26/#27 in this same repo — four overlapping PXE PRs that need reconciling; details in the review on #27.
Generated by Claude Code
This was referenced Sep 2, 2026
Collaborator
|
Superseded by merged PR #23 which published standalone PXE boot artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix\n\nAdds standalone PXE kernel/initrd artifacts, opt-in HTTP(S) DDI fetching with checksum verification, explicit target-disk selection, and PXE documentation. Existing embedded-DDI installs remain unchanged.\n\nRefs #14\n\nNote: release workflow asset-copy wiring is not included because GitHub App lacks workflows permission; workflow change is ready to apply once permission is granted.\n\n---\nFiled by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=gpt-5.6-luna