Answer the curators' 19 September round, and track what is left - #300
Merged
Merged
Conversation
They had added a round of findings to the report document that nothing here had answered, marked in purple for "resurfaced or still an issue on recheck". Read via the snapshot script; the document itself is theirs and untouched. Answered in CURATOR-REPORT.md, and the four that are real are now issues rather than lines in a Google Doc: - #296 the hit reaction count is one off, moving FDR and the entity ratios. The most serious of the round: everything else is something being hard to see, this is a number being wrong, and it propagates into two more. - #297 hovering a subpathway in the hierarchy does not highlight it on an EHLD, which the live site does. - #298 H2O and H+ disappear when zooming out, contradicting an OK on that row. The contradiction was in a comment, which is where such things get lost. - #299 PPTX entities move but an icon's border and centre are separate shapes, as is each reaction line segment. Grouping, not fewer shapes. And #154 is corrected rather than closed: #171 made the *table* readable, and the request -- which components of a complex are hit, shown on the diagram -- is still outstanding. They found the workaround themselves, which is not the same as it being fixed. **Right-click is not broken.** Two reported no menu, one adding "I use the touch pad though", and that is it: driven on beta, a right-click on an entity opens a 354x213 panel over the diagram with the entity's name and its three entries. A trackpad sends no right-click at all unless secondary click is enabled, so the report is about input rather than about the diagram. The answer says how to turn it on, and asks them to come back if Ctrl-click also does nothing, because then it is ours. Also answered: the four questions they left as comments, including two we cannot answer with an explanation because the honest answer is that the panel is unclear and that is our bug. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Found reviewing this before merging it, which is the point of doing that separately: the answer was confidently wrong about three of the five formats. I had written that a failed download produces an error and no file, so a file that arrives was produced. That is true of **GIF and PPTX** -- the two they asked about -- because those come from the render service, which builds the whole file before it answers, and `FileDownloadService` saves nothing unless the whole of it arrived and the server said it was good. It is not true of **SBML, SBGN and PDF**. Those come from the Java exporters, which stream while they generate, so a failure partway produces a truncated file that looks complete and carries no length to check against. `file-download.service.ts` says exactly this at the top, and I wrote the answer without reading it. The half I got wrong is the worse half to get wrong: a curator told "a file that arrives was produced" would stop opening the ones that can lie. Corrected, and the earlier claim is named rather than quietly replaced, because they may already have read it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curators had added a round of findings to their report document that nothing here had answered — marked in purple for "resurfaced or still an issue on recheck". Read via
~/curator-docs.sh --peek; the document is theirs and is untouched.Four real findings, now issues rather than lines in a Google Doc
#296 is the serious one. Everything else in the round is something being hard to see; that one is a number being wrong, and it propagates into two more numbers.
#298 is worth noting for how it was nearly lost. The row was marked OK and the contradiction was in a comment.
Right-click is not broken
Two reported no menu, one adding "I use the touch pad though" — and that is the answer. Driven on beta: a right-click on an entity opens a 354×213 panel over the diagram carrying the entity's name and its three entries. A trackpad sends no right-click at all unless secondary click is enabled. The report tells them how to turn it on, and asks them to come back if Ctrl-click also does nothing, because then it is ours.
#154 corrected rather than closed
#171 made the table readable. The actual request — which components of a complex are hit, shown on the diagram — is still outstanding. They found a workaround themselves, which is not the same as it being fixed.
Also answered
The four questions they left as comments, including two where the honest answer is that the panel is unclear and that is our bug, not something to explain away.
🤖 Generated with Claude Code