Async animals alert - #983
Open
still222 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I've tested it as an external patch, cannot build real multiplayer dll for some reason. If you can test it would be cool - host async server with 2 maps, have some pen animals (that have food need) in a pen and drift another map at least 30000 ticks (half a day) ahead. Without commit you will see "Hungry pen animals" and "Animals starving" alerts when viewed from another map, with commit you should see them only if any animals have their need.food <= 0f. When not in async postfix does nothing to save on iterations. |
still222
marked this pull request as ready for review
August 19, 2026 05:32
Renaming patch classes to be inline with the rest of the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla uses (mostly)
needs.food.TicksStarvingto determine if animals are hungry/starving. Which in async results in constant warnings, when viewed from another, higher tick map.Meanwhile vanilla humanlike trackers use
needs.food.Starving, no idea why it wasn't done to the animals in the first place.The most non-intrusive way I could come up with, was using postfix to filter the results and ensure animals actually hungry.
There is a separate bug for (async?) alerts, which results in them "jumping" around when hovered with a mouse. Not sure what causes it, but it's not this commit. With this commit if you see the alert, that means 100% there are starving animals, though sometimes (dont know exactly when or why) to get correct, non-jumpy tooltip, you have to find a correct map first. Without this commit alert will always show, sometimes jumpy, sometimes not, but they will be wrong most of the time.