Dashcam telemetry v0.1.0-alpha.1 for comma 3/3X and comma 4 - #1
Draft
spanconstant5 wants to merge 2885 commits into
Draft
spanconstant5 wants to merge 2885 commits into
spanconstant5 wants to merge 2885 commits into
Conversation
* tools/setup: skip native package managers if we can * revert that
* remove CarState.brake refs Intending to deprecate this field since it's set incorrectly by most car implementations, and (essentially) unused in openpilot. Everything should be using CarState.brakePressed. See commaai/opendbc#3338. * fix test_models.py
* bump * fix
* check angle matches safety * add to fuzzy * explicit * fix tesla * just real data for now, fix toyota * clean up
Update Python packages Co-authored-by: Vehicle Researcher <user@comma.ai>
* bitrate controller * ability to set the quality so a certain level, make message handler a switch case * distinct bitrate levels and exponential backoff of raising bitrate * add med level threshold * fix * fix * simplify * clean
* modeld leak * rm
* deep pre-req * modeld changes * fix parsing * comment * fix reporter
* Revert "modeld: fix capnp memory leak (commaai#38117)" This reverts commit 0f17a98. * Revert "fix memory leak from pycapnp 2.2+ (commaai#38001)" This reverts commit 294cb68. * downgrade * agnos 18.4
initialize on medium quality
* add vw meb exception * comment
* modeld: RL driving model with 3-file split Split the driving model into vision + off_policy + on_policy ONNX files and wire up the RL policy: - 3-file model split (vision / off_policy / on_policy), replacing the combined big_driving_policy/vision models - compiler updates for the split models - actually consume the policy action in modeld - add desire state to the driving model - model iterations (smoothness, off/on-policy weight updates) * modeld: update driving model * 1e72cf5a-785f-45ea-888f-28cdb14785de/100 * tinygrad hack * fix parsing * looser timing * big * Remove unnecessary modeld rebase changes * Tighten modeld split cleanup --------- Co-authored-by: Comma Device <device@comma.ai> Co-authored-by: Armandpl <adpl33@gmail.com>
…ized Kalman filter time (commaai#38124) * locationd: require finite filter time for valid livePose * cast to bool and rename
cap cpu core frequency
* Higher min vego * Use CV * Bump speed in simulated tests
usbgpu: pin modeld to core 7
* undeprecate curvature * use pid_log * bump * fix test * bump * bump * fix * tune saturation * bump * fix torque bar * bump * rm redundant * reduce sesitivity * pid * bump * reset opendbc * preserve sorting * bump opendbc
* trigger dm * rename * ci * opendbc bump
id4 release
op.sh: don't eval CMD, run argv directly so special chars work Previously op_run_command joined "$@" into a single string and eval'd it, which broke on inputs containing shell metacharacters. For example, 'op esim --download "LPA:1$[rsp.truphone.com]($url)$QRF-SPEEDTEST" name' would fail with a syntax error on the unquoted parens. Run "$@" instead and only use $* for the printed display string. Also quote the unquoted $@ in the other op_run_command callers.
rm tizi sounds
* tools: decompress in the python downloader * and zstd
show big model loading as permanent alert
* webrtc timeout after 5 mins * omit timeout for body
* bump version * update AGNOS 18.7 * update to production
* remove test_models * rm that * update test_models docs * restore car model test tool * leave dependencies unchanged
Revert "bump teleoprtc (commaai#38443)" This reverts commit 171f271.
This reverts commit 2895346.
* lint: check indentation * cleanup * happy * that was too much * happy
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a read-only dashcam and telemetry platform while preserving openpilot vehicle-control behavior. The feature branch is rebased from the fork's February 2025 base onto current commaai/openpilot master because official comma four (
mici) support postdates the old base.Implemented
fcamera.hevcsegments; no second encode and no burned-in source HUDtskdashrelease branch andv0.1.0-alpha.1tagChecks run
compileallover recorder, both HUD integrations, viewer, and importerHardware validation still required
No comma 3, comma 3X, comma 4, or in-vehicle validation is claimed. Owners must verify UI geometry, daylight/night readability, thermal and write overhead, normal shutdown/recovery, 31+ minute rotation, GPS source selection, HEVC alignment at boundaries, and unchanged control behavior. The install guide contains separate comma 4 compact-layout checks.
Known limitations
Exact Toyota TODOs
No speculative CAN addresses were added.
Installation and testing
feature/dashcam-telemetry-v1v0.1.0-alpha.1tskdashspanconstant5/openpilot:installer.comma.ai/spanconstant5/tskdashcomma4TSKdashcam, so use the documented SSH install until it is renamed/mirroredtools\telemetry_importer\Import.battools\telemetry_viewer\requirements.txt, then runtools\telemetry_viewer\ReplayViewer.batpython -m openpilot.tools.telemetry_viewer.generate_sample sample_telemetrySee
docs/INSTALL_COMMA.mdfor the complete hardware checklist.