test: keep two Windows-only flakes off the release gate - #283
Merged
Merged
Conversation
Main CI failed on Windows twice in this alignment, each time in a test the change under test never touched: - definition_grouping named its temp project by pid and nanoseconds only, and parallel tests in the file shared the prefix; Windows' clock gave two of them the same nanosecond, so the second `init` found the first's namespace. A sequence number keeps the directories apart. - the watcher's root .gitignore reload test waited two seconds for a full reconcile, which a loaded Windows runner has exceeded. It now waits ten; the assertions are unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 158 158
Lines 97623 97623
=======================================
Hits 93028 93028
Misses 4595 4595
🚀 New features to boost your workflow:
|
This was referenced Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Windows-only test flakes failed main CI during the v1.6.1 alignment, each in a test the change under test never touched (
4231ee5run 36795226602,678927crun 36817359513). The release workflow waits for an exact-SHACI Successon the release commit, so either flake could stall the 0.51.0 release.definition_grouping: the temp project was named by pid and nanoseconds only, and the file's parallel tests share the prefix. Windows' clock gave two of them the same nanosecond, so the secondinitfailed with "cannot create an initial index lease because the namespace already exists". A process-wide sequence number keeps the directories apart.watcher::tests::root_gitignore_reload_reconciles_and_readmits_sources: waited two seconds for a full reconcile after a.gitignorechange, which a loaded Windows runner exceeded (gitignore-removal full sync: Timeout). It now waits ten; the assertions are unchanged.Test-only; no product or golden impact.
Verification
🤖 Generated with Claude Code