ci: leave release-please's scaffold.json bump out of oxfmt - #284
Merged
Merged
Conversation
The release PR for 0.51.0 failed `make check`: release-please's JSON extra-file updater rewrites the whole of `.github/scaffold.json` to bump `placeholders.CURRENT_VERSION`, expanding the inline `addons` array, and oxfmt rejects the expanded form. Merged as is, the same check would fail main CI on the release commit and with it the release workflow's exact-SHA CI gate. The file joins the release-please-owned entries in `.oxfmtignore`, and is committed in the shape release-please writes, so a release PR now changes only the version line.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 158 158
Lines 97623 97623
=======================================
+ Hits 93028 93029 +1
+ Misses 4595 4594 -1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This was referenced Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 0.51.0 release PR (#272) fails
make checkon Linux:oxfmt --checkrejects.github/scaffold.json(job 110240240573, run 36820051008). Release-please's JSON extra-file updater rewrites the whole file to bumpplaceholders.CURRENT_VERSIONand expands the inline"addons": ["codecov"]array, which oxfmt formats back inline. The file entered release-please'sextra-filesin #271, so this release is the first to hit it. Merged as is, the same check would fail main CI on the release commit, and the release workflow waits for an exact-SHACI Successthere, so the release could not publish..github/scaffold.jsonjoins the release-please-owned entries in.oxfmtignore(besidechangelog/,.release-please-manifest.jsonandrelease-please-config.json).No product, test or golden impact.
Verification
oxfmt --check --ignore-path .oxfmtignore .passes (42 files),scripts/check-workspace-versions.shpasses, and its harnessscripts/tests/check-workspace-versions.test.shreports 12 passed, 0 failed.--no-verifyafter those targeted checks; CI runs the full gate.🤖 Generated with Claude Code