docs(design): mark direction D as built - #301
Merged
Merged
Conversation
The spec still called itself a draft with no UI code, and left the light variant open. Point the status at the build and its deviation log, and record that §3.6 settled the light variant and that the build turned ligatures off for the owner to review.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 197 197
Lines 108387 108387
=======================================
+ Hits 103023 103025 +2
+ Misses 5364 5362 -2 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A docs-only follow-up to #298 and #300, acting on the final goal review's one note.
docs/design/viewer-d.mdstill said "Design draft … No UI code exists yet", and its §13 listed the light variant as an open question.docs/ui.md("Direction D as built").prefers-color-schemeuntil the reader picks System, Dark or Light.The rest of the spec is unchanged.
Verification
make docs-checkandmake fmt-checkpass. The file is in.oxfmtignore, so it is not reformatted. There is no code change.🤖 Generated with Claude Code