Conversation
librowski
added this pull request to stack #143
September 14, 2026 10:59
librowski
marked this pull request as ready for review
September 14, 2026 13:15
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 14, 2026 13:15
librowski
force-pushed
the
ds2-menu-item-selected
branch
from
September 14, 2026 19:54
51412dd to
294fd7f
Compare
piotrblaszczyk
approved these changes
Sep 15, 2026
A menu whose items define selected renders them as a Base UI radio group, so the current entry carries menuitemradio and aria-checked. Selected list entries (menu radio items and Select options) move from the solid accent fill to the ui/bg/selected role with default text and a selected-hover state. The language menu marks the current language.
librowski
force-pushed
the
ds2-menu-item-selected
branch
from
September 15, 2026 08:54
294fd7f to
7e8c791
Compare
librowski
removed this pull request from stack #143
September 15, 2026 09:00
librowski
added this pull request to stack #151
September 15, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Design answer to the "selected in lists" questions (DR-029/030/036): a new
ui/bg/selectedrole (brand fill subtle, same in both themes) withselected-hover, menu items with Selected / Selected+Hover states, selects sharing the same item styling. The role landed in the 14.09 export (#138, this PR's base).list-item.module.css(shared byMenuItemandSelectOption): selected background →ui/bg/selected, hovered or highlighted selected →ui/bg/selected-hover, text →ui/text/defaultinstead of on-accent white. The dark-theme override of the old solidacc1-500fill goes away, the token carries the theme. New public property--wb-public-list-item-background-color-selected-hover.Menu: items acceptselected. When any item defines it, the popup renders a Base UIRadioGroupand the items becomeRadioItems (menuitemradio,aria-checked,data-checked,closeOnClick). Menus without a selection are unchanged.Selectoptions already exposedata-selected, so they pick up the new colors without code changes;SelectOptionstays because both components already share one stylesheet.selectedwith an example; the props table picks up the JSDoc.Verification
ui typecheck, eslint, stylelint,
menu.spec.tsx(radio group,aria-checked,data-checked), build withcheck:built-css; sdk typecheck and language selector spec (3 tests); docs typecheck. Changesets: ui minor, sdk patch.