Conversation
- persist: strip the runtime dragging flag alongside measured and selected, drop dragging from the bundled templates, cover getStoreDataForIntegration - node description: document the contain: inline-size constraint - connectable item: rewrite the width decision log with the current numbers and a status section; reword the tooltip changeset - menu: lay out the RadioGroup wrapper as a column so the list-box gap applies - ui specs: unmount the React root after each test - palette: forward disabled in the custom template guide and the demo multi-port template, document it on NodePanel.Root, reword the changeset
librowski
added this pull request to stack #151
September 15, 2026 10:25
librowski
marked this pull request as ready for review
September 15, 2026 11:12
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 15, 2026 11:12
This was referenced Sep 15, 2026
| <NodePanel.Root selected={selected}> | ||
| <NodePanel.Root selected={selected} disabled={disabled}> | ||
| <NodePanel.Header> | ||
| <NodeIcon icon={iconElement} /> |
Contributor
There was a problem hiding this comment.
The guide snippet and the changeset's migration note forward disabled to all three parts, but here only NodePanel.Root gets it. NodeIcon and NodeDescription mute only through their own prop, and the shell's disabled swaps just the background, so the read-only palette shows this entry with a faded surface but full-contrast icon and text. Could we pass disabled={disabled} on lines 46-47 as well?
piotrblaszczyk
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the second review round on the canvas stack (#124, #126, #136, #139, #140). Those PRs are approved, so the fixes land here on top of #149 instead of being force-pushed into the reviewed branches.
Changes
Persist without measured (#124)
getNodesWithoutDynamicValuesalso strips the runtimedraggingflag; the bundled Demo and AI Studio templates no longer carrydragging: false.getStoreDataForIntegrationgets two boundary tests: default output has nomeasured,draggingor selection and empty routing points;shouldSkipDynamicValues: falsereturns the live store arrays.dragging.Node text ellipsis (#126)
contain: inline-sizeconstraint: the block needs an ancestor with a definite inline size and collapses to zero width insideinline-flexorfit-contentwrappers.Node body spacing (#136)
## Statussection; the dated update sections and the external tracker reference are gone.Menu item selected (#139)
Menu.RadioGrouprenders its owndiv[role="group"], which swallowed the popup's column gap. The wrapper now gets.groupfromlist-box.module.css(column flex,--wb-public-list-box-gap). Measured in Demo: 4px between radio items, same as plain items.menu.spec.tsxandnode-panel.spec.tsxunmount the React root after each test.Palette node states (#140)
disabledtoNodePanel.Root,NodeIconandNodeDescription; the guide explains when the palette passesselectedanddisabled.node-panel.mdxlistsdisabled?: booleanonNodePanel.Root.WorkflowNodeTemplateProps.disabledwith a migration note for custom templates.Not changed
Checks
pnpm -F @workflowbuilder/ui build(includescheck:built-css), vitest ui 74 and sdk 218 passing, stylelint ui/sdk clean, typecheck ui/sdk/demo/ai-studio/docs clean.