Conversation
Both app tsconfigs excluded spec and test files, so tsc never saw them and CI passed with type errors in tests. The exclusion predates the first tests in these apps; removing it needs no code changes.
| @@ -9,5 +9,5 @@ | |||
| "verbatimModuleSyntax": true, | |||
| "types": ["node", "vite/client", "vite-plugin-svgr/client"] | |||
There was a problem hiding this comment.
Since test.globals: true is on in both apps, could you add "vitest/globals" to types here and in apps/demo/tsconfig.json, like packages/sdk and packages/ui do? Otherwise a spec written in the ui style (describe without an import) passes vitest but fails the new typecheck with TS2593 and a confusing @types/jest hint. I checked: with it added, such a spec type-checks and the app stays green.
| "types": ["node", "vite/client", "vite-plugin-svgr/client"] | ||
| }, | ||
| "exclude": ["src/**/*.spec.ts", "src/**/*.test.ts", "src/**/*.spec.tsx", "src/**/*.test.tsx", "dist"] | ||
| "exclude": ["dist"] |
There was a problem hiding this comment.
Small accuracy note on the summary and the commit message: pr-check.yml never type-checks demo or ai-studio (its header comment says so), so CI was not the thing staying green. The guard this restores is the pre-commit tsc --noEmit from lint-staged and pnpm check. Worth rewording before the squash so git blame tells the right story.
2 participants
Summary
apps/demoandapps/ai-studioexcludedsrc/**/*.spec.*andsrc/**/*.test.*from their tsconfig, sotsc --noEmitnever type-checked tests and CI stayed green with type errors in them. Both exclusions come from the initial 2.0.0 import, before either app had a test.packages/sdkandpackages/uialready type-check their specs.Neither tsconfig emits anything (vite builds the apps), so the exclusion only removed a check.
Changes
apps/demo/tsconfig.jsonandapps/ai-studio/tsconfig.json:excludekeeps onlydist.Checks
pnpm -F @workflow-builder/demo typecheckandpnpm -F ai-studio typecheckpass with no code changes; both AI Studio test files importvitestexplicitly.const probe: number = 'x'appended todetect-format.test.tsfails the AI Studio typecheck, so tests are now covered.