Skip to content

chore: type-check spec files in demo and ai-studio #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
librowski wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore: type-check spec files in demo and ai-studio #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/ai-studio/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
"verbatimModuleSyntax": true,
"types": ["node", "vite/client", "vite-plugin-svgr/client"]

@piotrblaszczyk piotrblaszczyk Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since test.globals: true is on in both apps, could you add "vitest/globals" to types here and in apps/demo/tsconfig.json, like packages/sdk and packages/ui do? Otherwise a spec written in the ui style (describe without an import) passes vitest but fails the new typecheck with TS2593 and a confusing @types/jest hint. I checked: with it added, such a spec type-checks and the app stays green.

},
"exclude": ["src/**/*.spec.ts", "src/**/*.test.ts", "src/**/*.spec.tsx", "src/**/*.test.tsx", "dist"]
"exclude": ["dist"]

@piotrblaszczyk piotrblaszczyk Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small accuracy note on the summary and the commit message: pr-check.yml never type-checks demo or ai-studio (its header comment says so), so CI was not the thing staying green. The guard this restores is the pre-commit tsc --noEmit from lint-staged and pnpm check. Worth rewording before the squash so git blame tells the right story.

}
2 changes: 1 addition & 1 deletion apps/demo/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
"verbatimModuleSyntax": true,
"types": ["node", "vite/client", "vite-plugin-svgr/client"]
},
"exclude": ["src/**/*.spec.ts", "src/**/*.test.ts", "src/**/*.spec.tsx", "src/**/*.test.tsx", "dist"]
"exclude": ["dist"]
}
Loading