Skip to content

test(candidate-execution): use protected trace writes in fixtures - #1106

Merged
drewstone merged 1 commit into
mainfrom
test/candidate-trace-writes-20260905
Sep 6, 2026
Merged

test(candidate-execution): use protected trace writes in fixtures#1106
drewstone merged 1 commit into
mainfrom
test/candidate-trace-writes-20260905

Conversation

@drewstone

@drewstone drewstone commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Candidate execution fixtures wrote raw trace IDs directly to storage.
When an ID matched a redaction rule, finalization could not find the protected record.
This caused the single failure in main CI.

Use the supplied trace store for all 19 affected fixture writes.
Force a sensitive-looking ID in the receipt test and inspect the stored identity when checking redaction.
Production code and credential protection are unchanged.

Validation:

  • A fixed sensitive-looking ID reproduced the same failure before the repair.
  • All 30 execution and redaction tests passed after the repair.
  • Biome, the version check, and commit hooks passed.
  • PR CI and merged main CI passed all four jobs.
  • Both Ubuntu runs passed 3,564 tests with six conditional skips, across 281 passing and two skipped files.
  • Merged commit e28a6b64c0a3f09ee6463f4f5e4e79d6938cc56c has the exact reviewed tree.

@drewstone
drewstone merged commit e28a6b6 into main Sep 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant