fix(http): recursively map nested uploaded files - #2255
Merged
Conversation
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit d698ba0 |
Member
|
I'd prefer a test that actually exercises the reported behavior, other than that, LGTM. #[Test]
public function nested_uploaded_files_are_mapped_to_uploads(): void
{
$request = $this->createServerRequest('POST')->withUploadedFiles([
// ...
]);
$mappedRequest = $this->mapper->map(
from: $request,
to: GenericRequest::class,
);
// asserts
} |
Contributor
Author
|
Thanks @xHeaven - I updated the test |
innocenzi
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSR-7 exposes array-style file inputs, such as
files[]orfiles[avatar], as nested arrays. The mapper previously assumed a single-level array with a callback typed toUploadedFileInterface, so passing a nested array threwTypeError.Uploaded files are now mapped recursively to preserve this nested structure, and the
$filesdocblocks onRequestandIsRequesthave been widened toarray<array-key, Upload|array>.Runtime behaviour for standard file uploads is unchanged, though static analysis tools may report new notices in code that assumes
Upload[].