Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/http/src/IsRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ trait IsRequest
#[SkipValidation]
private(set) array $query;

/** @var \Tempest\Http\Upload[] */
/** @var array<array-key, \Tempest\Http\Upload|array> */
#[SkipValidation]
private(set) array $files;

Expand Down
21 changes: 17 additions & 4 deletions packages/http/src/Mappers/PsrRequestToGenericRequestMapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ public function map(mixed $from, mixed $to): GenericRequest

parse_str($from->getUri()->getQuery(), $query);

$uploads = array_map(
fn (UploadedFileInterface $uploadedFile) => new Upload($uploadedFile),
$from->getUploadedFiles(),
);
$uploads = $this->createUploads($from->getUploadedFiles());

return map([
'method' => $this->requestMethod($from, $data),
Expand Down Expand Up @@ -88,6 +85,22 @@ public function map(mixed $from, mixed $to): GenericRequest
->to(GenericRequest::class);
}

/**
* Array-style file inputs, such as `files[]`, are exposed by PSR-7 as nested arrays.
*
* @param array<array-key, UploadedFileInterface|array> $uploadedFiles
* @return array<array-key, Upload|array>
*/
private function createUploads(array $uploadedFiles): array
{
return array_map(
fn (UploadedFileInterface|array $uploadedFile) => $uploadedFile instanceof UploadedFileInterface
? new Upload($uploadedFile)
: $this->createUploads($uploadedFile),
$uploadedFiles,
);
}

private function requestMethod(PsrRequest $request, array $data): Method
{
$originalMethod = Method::from($request->getMethod());
Expand Down
2 changes: 1 addition & 1 deletion packages/http/src/Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface Request

public array $query { get; }

/** @var \Tempest\Http\Upload[] $files */
/** @var array<array-key, \Tempest\Http\Upload|array> $files */
public array $files { get; }

/** @var Cookie[] $cookies */
Expand Down
35 changes: 35 additions & 0 deletions tests/Integration/Route/PsrRequestToGenericRequestMapperTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,31 @@ public function files(): void
$this->assertSame('application/octet-stream', $upload->getClientMediaType());
}

#[Test]
public function nested_files(): void
{
/** @var GenericRequest $request */
$request = $this->mapper->map(
from: $this->http->makePsrRequest('/', files: [
'avatar' => $this->createUploadedFile('avatar.png'),
'documents' => [
$this->createUploadedFile('one.txt'),
'contract' => $this->createUploadedFile('contract.pdf'),
],
]),
to: Request::class,
);

$this->assertInstanceOf(Upload::class, $request->files['avatar']);
$this->assertSame('avatar.png', $request->files['avatar']->getClientFilename());

$this->assertInstanceOf(Upload::class, $request->files['documents'][0]);
$this->assertSame('one.txt', $request->files['documents'][0]->getClientFilename());

$this->assertInstanceOf(Upload::class, $request->files['documents']['contract']);
$this->assertSame('contract.pdf', $request->files['documents']['contract']->getClientFilename());
}

#[Test]
public function body_field_in_body(): void
{
Expand Down Expand Up @@ -144,4 +169,14 @@ public function unencrypted_cookies_are_discarded(): void
$this->assertSame($cookies['foo']->expiresAt, -1);
$this->assertSame($cookies['foo']->value, '');
}

private function createUploadedFile(string $filename): UploadedFile
{
return new UploadedFile(
streamOrFile: new Stream('php://temp', 'r+'),
size: 0,
errorStatus: UPLOAD_ERR_OK,
clientFilename: $filename,
);
}
}
Loading