Skip to content

feat(release): Push git tag to remote before publishing release #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomas-vilte merged 1 commit into from
Jul 30, 2026
Merged

feat(release): Push git tag to remote before publishing release #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/commands/release/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,19 @@ func createReleaseAction(releaseSvc releaseService, trans *i18n.Translations, re
}

if cmd.Bool("publish") {
// The tag above was only created locally — GitHub can't attach
// a release to a tag it has never seen, and silently falls
// back to an "untagged-..." release instead of erroring.
fmt.Println(trans.GetMessage("release.pushing_tag", 0, struct{ Version string }{release.Version}))
if err := releaseSvc.PushTag(ctx, release.Version); err != nil {
log.Error("failed to push tag before publishing",
"error", err,
"version", release.Version,
"duration_ms", time.Since(start).Milliseconds())
return fmt.Errorf("%s", trans.GetMessage("release.error_pushing_tag", 0, struct{ Error string }{err.Error()}))
}
fmt.Println(trans.GetMessage("release.push_success", 0, struct{ Version string }{release.Version}))

notes.Changelog = FormatReleaseMarkdown(release, notes, trans)

fmt.Println(trans.GetMessage("release.publishing_release", 0, nil))
Expand Down
4 changes: 4 additions & 0 deletions internal/commands/release/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ func TestCreateCommand_WithPublish(t *testing.T) {
mockService.On("GenerateReleaseNotes", mock.Anything, release).Return(notes, nil)
mockService.On("CreateTag", mock.Anything, "v1.0.0", mock.Anything).Return(nil)
mockService.On("TagExists", mock.Anything, mock.Anything).Maybe().Return(false)
mockService.On("PushTag", mock.Anything, "v1.0.0").Return(nil)

mockService.On("PublishRelease", mock.Anything, release, notes, false, false, mock.Anything).Return(nil)

Expand All @@ -205,6 +206,7 @@ func TestCreateCommand_WithPublishAndExistingTag(t *testing.T) {
mockService.On("EnrichReleaseContext", mock.Anything, mock.Anything).Return(nil)
mockService.On("GenerateReleaseNotes", mock.Anything, release).Return(notes, nil)
mockService.On("TagExists", mock.Anything, "v1.0.0").Return(true)
mockService.On("PushTag", mock.Anything, "v1.0.0").Return(nil)
mockService.On("PublishRelease", mock.Anything, release, notes, false, false, mock.Anything).Return(nil)

err := runCreateTest(t, "y\n", []string{"--publish"}, mockService)
Expand All @@ -224,6 +226,7 @@ func TestCreateCommand_WithPublishDraft(t *testing.T) {
mockService.On("GenerateReleaseNotes", mock.Anything, release).Return(notes, nil)
mockService.On("CreateTag", mock.Anything, "v1.0.0", mock.Anything).Return(nil)
mockService.On("TagExists", mock.Anything, "v1.0.0").Return(false)
mockService.On("PushTag", mock.Anything, "v1.0.0").Return(nil)

mockService.On("PublishRelease", mock.Anything, release, notes, true, false, mock.Anything).Return(nil)

Expand All @@ -244,6 +247,7 @@ func TestCreateCommand_PublishError(t *testing.T) {
mockService.On("GenerateReleaseNotes", mock.Anything, release).Return(notes, nil)
mockService.On("CreateTag", mock.Anything, "v1.0.0", mock.Anything).Return(nil)
mockService.On("TagExists", mock.Anything, "v1.0.0").Return(false)
mockService.On("PushTag", mock.Anything, "v1.0.0").Return(nil)

mockService.On("PublishRelease", mock.Anything, release, notes, false, false, mock.Anything).Return(errors.New("publish error"))

Expand Down
Loading