dudescab: align Finish and destructor with c# - #66
Merged
Merged
Conversation
KarotsSugarpie
pushed a commit
to PinCabOs/PinCabOS
that referenced
this pull request
Aug 31, 2026
…sh sortie de table PinCabOS chargeait DEUX libdof differents via deux overlays : - overlays/vpinfe-dof-ledwiz-hidraw-stable/ -> vpinfe (menu), LD_LIBRARY_PATH - overlays/libdof-ledwiz-hidraw-stable/ -> VPX (jeu), LD_PRELOAD Rien ne les synchronisait. Le correctif du use-after-free DudesCab au teardown (vpinball/libdof#66) n'avait ete applique qu'a l'overlay MENU ; l'overlay EN JEU restait sur le libdof stock buggé -> avec une Dude's Cab + un Teensy, la sortie de table plantait par intermittence (double free / free(): invalid pointer, backtrace : DudesCab::~DudesCab -> SendCommand -> hid_write). Fix : un seul binaire canonique (overlays/libdof-canonical/libdof.so.0.4.7, libdof #66 officiel) reference par SYMLINK depuis les deux overlays. Mettre a jour libdof = remplacer un seul fichier ; menu et jeu toujours d'accord ; plus de divergence. Launchers inchanges (ils pointent sur les dossiers overlay). Au passage : l'overlay menu passe de notre build custom au #66 officiel, et l'overlay jeu passe du stock au #66. Repo allege (2 binaires 11 Mo -> 1 + 2 symlinks). Valide sur cab reel : 0 crash sur de nombreuses sorties de table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #65