Conversation
JoBalk
commented
Aug 13, 2026
JoBalk
commented
Collaborator
- add Minitwin::Error marker module and five exception classes
- raise Minitwin::DefinitionError/CompositionError/CoercionError from dsl.rb
- raise Minitwin::ParseError from constructors.rb; wrap JSON::ParserError in from_json
- raise Minitwin::AliasError from initialization.rb
- document Minitwin's gem-specific exception classes
webit-stevereinke
requested changes
Sep 3, 2026
Comment on lines
+65
to
+66
| rescue Minitwin::Error | ||
| raise |
There was a problem hiding this comment.
Soll hier wirklich eine "leere" Exception geworfen werden?
Collaborator
There was a problem hiding this comment.
Nein, die ist nicht leer. Ein raise in einem rescue re-raised die Exception exakt so, wie sie ist. Das ist erforderlich, damit die zweite rescue Klausel keine von unseren neuen Typen schluckt. (die erben von den dort gefangenen) Aus diesem Grund spielt die Reihenfolge hier eine große Rolle. Ich werde einen Kommentar ergänzen, damit das klar wird.
webit-stevereinke
requested review from
webit-stevereinke
and removed request for
stevereinke
September 3, 2026 13:22
webit-stevereinke
assigned
JoBalk and
webit-schwarzer and unassigned
stevereinke,
webit-stevereinke and
JoBalk
webit-schwarzer
force-pushed
the
20260811_rsc_typed-exceptions
branch
from
September 7, 2026 14:02
fb44859 to
134576b
Compare
* add Minitwin::Error marker module and five exception classes * raise Minitwin::DefinitionError/CompositionError/CoercionError from dsl.rb * raise Minitwin::ParseError from constructors.rb; wrap JSON::ParserError in from_json * raise Minitwin::AliasError from initialization.rb * document Minitwin's gem-specific exception classes
webit-schwarzer
force-pushed
the
20260811_rsc_typed-exceptions
branch
from
September 7, 2026 14:19
134576b to
e329c1b
Compare
webit-schwarzer
requested review from
webit-schwarzer
and removed request for
webit-schwarzer
September 7, 2026 14:21
webit-stevereinke
requested changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.