-
Notifications
You must be signed in to change notification settings - Fork 1
[FEATURE] add typed exceptions #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoBalk
wants to merge
1
commit into
main
Choose a base branch
from
20260811_rsc_typed-exceptions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| class Minitwin | ||
| # Marker: `rescue Minitwin::Error` catches every gem-specific error. | ||
| module Error; end | ||
|
|
||
| # DSL used incorrectly — fails at class-definition time. | ||
| class DefinitionError < ::ArgumentError | ||
| include Error | ||
| end | ||
|
|
||
| # A source object cannot supply a composed property. | ||
| class CompositionError < ::RuntimeError | ||
| include Error | ||
| end | ||
|
|
||
| # A dynamic alias is invalid, forbidden, or collides. | ||
| class AliasError < ::ArgumentError | ||
| include Error | ||
| end | ||
|
|
||
| # A value cannot be coerced into the expected twin type. | ||
| class CoercionError < ::TypeError | ||
| include Error | ||
| end | ||
|
|
||
| # Input data is structurally unusable (JSON, wrong object type). | ||
| class ParseError < ::ArgumentError | ||
| include Error | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Generated from lib/minitwin/errors.rb with RBS::Inline | ||
|
|
||
| class Minitwin | ||
| # Marker: `rescue Minitwin::Error` catches every gem-specific error. | ||
| module Error | ||
| end | ||
|
|
||
| # DSL used incorrectly — fails at class-definition time. | ||
| class DefinitionError < ::ArgumentError | ||
| include Error | ||
| end | ||
|
|
||
| # A source object cannot supply a composed property. | ||
| class CompositionError < ::RuntimeError | ||
| include Error | ||
| end | ||
|
|
||
| # A dynamic alias is invalid, forbidden, or collides. | ||
| class AliasError < ::ArgumentError | ||
| include Error | ||
| end | ||
|
|
||
| # A value cannot be coerced into the expected twin type. | ||
| class CoercionError < ::TypeError | ||
| include Error | ||
| end | ||
|
|
||
| # Input data is structurally unusable (JSON, wrong object type). | ||
| class ParseError < ::ArgumentError | ||
| include Error | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soll hier wirklich eine "leere" Exception geworfen werden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nein, die ist nicht leer. Ein
raisein einemrescuere-raised die Exception exakt so, wie sie ist. Das ist erforderlich, damit die zweiterescueKlausel keine von unseren neuen Typen schluckt. (die erben von den dort gefangenen) Aus diesem Grund spielt die Reihenfolge hier eine große Rolle. Ich werde einen Kommentar ergänzen, damit das klar wird.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Danke, mach das gern.