Robot Kalman Filters - #3906
Open
sunghyuneun wants to merge 56 commits into
Open
Robot Kalman Filters#3906sunghyuneun wants to merge 56 commits into
sunghyuneun wants to merge 56 commits into
Conversation
sunghyuneun
requested review from
Andrewyx,
StarrryNight and
nycrat
as code owners
August 27, 2026 21:13
sunghyuneun
marked this pull request as draft
August 27, 2026 21:13
…into sunghyuneun/robot_filter
…into sunghyuneun/robot_filter
…into sunghyuneun/robot_filter
sunghyuneun
marked this pull request as ready for review
September 3, 2026 18:12
…into sunghyuneun/robot_filter
man fuck you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
note: i am lazy and i want auto-formatting fixes so i marked it as open but it's not in a final state but it's 95% there i think (excluding physical tests)
Makes changes to robot filter. Notable changes:
Notably a lot of the files changed are part of PR #3900, because I built upon a lot of the work there. Files that should actually be reviewed include:
robot_filter.cpp,robot_filter.h,robot_filter_test.cpp,robot_team_filter.cpp,robot_team_filter_test.cppTesting with real robots is incomplete, and some constants should be changed.
Testing Done
Unit tests modified
Resolved Issues
Resolves #3701, fixes #1717.
Length Justification and Key Files to Review
Ball Kalman Filter is +529 -503, therefore this PR is +413, -101.
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue