Skip to content

Post-EKF robot localizer cleanup - #3957

Open
StarrryNight wants to merge 48 commits into
samuel/use_ekf_pushfrom
samuel/post_ekf_cleanup
Open

StarrryNight wants to merge 48 commits into
samuel/use_ekf_pushfrom
samuel/post_ekf_cleanup

Conversation

@StarrryNight

Copy link
Copy Markdown
Contributor

Description

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

annieisawesome2 and others added 30 commits September 12, 2026 20:24
* use ci_cmd_with_delay instead of threading.Timer

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* Move all play selection behavior to PlaySelectionFSM

* [pre-commit.ci lite] apply automatic fixes

* Remove ternary operator

---------

Co-authored-by: Apeiros-46B <Apeiros-46B@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@StarrryNight
StarrryNight added this pull request to stack #3955 September 15, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants