Conversation
nycrat
force-pushed
the
avah/combine_simulated_and_field_tests
branch
5 times, most recently
from
June 1, 2026 18:24
f7b544d to
db5f8e2
Compare
4 tasks
nycrat
force-pushed
the
avah/combine_simulated_and_field_tests
branch
from
June 14, 2026 03:02
db5f8e2 to
fd08dcd
Compare
nycrat
force-pushed
the
avah/combine_simulated_and_field_tests
branch
from
June 16, 2026 22:08
d5f2675 to
a49d254
Compare
2 tasks
Member
Author
|
@annieisawesome2 I addressed comments, ready for re-review if you have time |
nycrat
force-pushed
the
avah/combine_simulated_and_field_tests
branch
from
June 21, 2026 22:00
fa2aba5 to
e42ab95
Compare
Contributor
Sounds good I will finish up tonight |
nycrat
force-pushed
the
avah/combine_simulated_and_field_tests
branch
from
June 22, 2026 17:53
8fd923b to
42e8972
Compare
annieisawesome2
previously approved these changes
Jun 22, 2026
| time_elapsed_s += time.time() - processing_start_time | ||
|
|
||
| # Check that all eventually validations are eventually valid | ||
| validation.check_validation(eventually_validation_proto_set) |
Contributor
There was a problem hiding this comment.
All the new changes look great! One small thing with the world timeout fix. If no world is received, here it references eventually_validation_proto_set before it is assigned i think. we can probs just fix with pytest.fail.. in the except queue.Empty block?
Member
Author
There was a problem hiding this comment.
You're right I didn't notice that. I rewrote it to raise an exception since that is the same mechanism the test validations use to signal a test failure
4 tasks
annieisawesome2
previously approved these changes
Jun 23, 2026
This was referenced Jun 25, 2026
annieisawesome2
previously approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a stacked PR: #3744 #3806 #3807
This PR combines simulated and field gameplay test runners under the common TbotsTestRunner interface. This allows all tests to be run as either field tests or simulated tests with just a different flag passed into the
bazel testcommand.This PR contains many refactoring changes to our existing python testing framework. These changes were important to improving code quality while implementing the changes, and they will make it easier to implement #3369 in the future.
./tbots.py test move_tactic_test./tbots.py test move_tactic_field_test./tbots.py test move_tactic_test --run_field_test./tbots.py test move_tactic_field_test --run_field_testTesting Done
Resolved Issues
resolves #2908
resolves #2856 cause this PR just gets rid of simulated aggregate tests
resolves #3784
Length Justification and Key Files to Review
A lot of just renaming and combining the simulated_tests and field_tests under the gameplay_tests package. None of the logic is changed for validations and existing tests.
Important not just refactoring changes to review:
(in src/software/gameplay_tests)
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue