Replace KF in robot localizer with EKF - #3954
Open
StarrryNight wants to merge 16 commits into
Open
StarrryNight wants to merge 16 commits into
StarrryNight wants to merge 16 commits into
Conversation
StarrryNight
added this pull request to stack #3955
September 15, 2026 03:23
StarrryNight
marked this pull request as ready for review
September 15, 2026 03:35
StarrryNight
requested review from
Andrewyx,
nycrat,
sauravbanna and
williamckha
as code owners
September 15, 2026 03:35
Thunderbots
force-pushed
the
samuel/use_ekf_push
branch
from
September 15, 2026 05:06
323b750 to
07a8695
Compare
StarrryNight
force-pushed
the
samuel/use_ekf_push
branch
from
September 16, 2026 05:07
cb2b104 to
43b38f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces linear kalman filter of robot localizer with an Extended kalman filter
Testing Done
Tested on sim by hooking up er force simulator with an instance of robot localizer. The robot localizer takes in vision packets generated and synthesize noisy IMU and motor data as filter update inputs.
Results are testing by running sim under identical situations except for robot localizer:

enable realism, CI mode, and record stats for 1 minute
Videos of XY tracking:
Resolved Issues
Length Justification and Key Files to Review
Before:
Position estimation is okay, sometimes drifts a bit when turning
Screencast from 2026-09-14 21-58-47.webm
Velocity estimation is horrible and noisy. Notable delay of estimation from ground truth.
Screencast from 2026-09-14 21-58-20.webm
After
Position estimation is notably better during turning
Screencast from 2026-09-14 21-56-53.webm
Big improvement in velocity tracking. The control input fixed the latency from vision.
Screencast from 2026-09-14 21-54-19.webm
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue