Skip to content

fix(ui): repair broken resource keys and give warning popups an icon - #318

Open
gmmcosta15 wants to merge 3 commits into
test/resource-key-guardfrom
fix/resource-broken-refs
Open

fix(ui): repair broken resource keys and give warning popups an icon#318
gmmcosta15 wants to merge 3 commits into
test/resource-key-guardfrom
fix/resource-broken-refs

Conversation

@gmmcosta15

Copy link
Copy Markdown
Collaborator

Description

  • Bug fix

  • Repair broken :/ keys in networkWindow, printTab, babystepPage, probeHelperPage, slider_selector_page.

  • Repair the z-adjust back icon in controlStackedWidget.

  • Give the warning severity its own popup icon; clear it for unknown severity.

  • Harden the BlocksLabel icon guard against a null pixmap.

  • Delete dead pixmap references.

Motivation

Every key here painted blank on the panel. Empties XFAIL_KEYS.

Tests

make check green; XFAIL_KEYS now empty.

Screenshots

Pending on-device check: warning and error popups share the octagon glyph, differing only by fill (#E7E147 vs #CA4949).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests that update python code UI/UX User Interface what changed with this code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant