refactor(pixmap): route network, header and files icons through BlocksPixmap - #324
Open
gmmcosta15 wants to merge 1 commit into
Open
refactor(pixmap): route network, header and files icons through BlocksPixmap#324gmmcosta15 wants to merge 1 commit into
gmmcosta15 wants to merge 1 commit into
Conversation
gmmcosta15
added
Refactor
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code refactor
Convert
networkWindow,mainWindow,filesPage.Replace the ad-hoc wifi string building with
Icon.wifi(bars, protected).Update the network and panel fixtures for the new call path.
Net 102 lines removed.
Motivation
The hot paths: the network list rebuilds icons per scan, the header per status change, the files page per row.
Tests
make checkgreen.