chore(ui): dedupe 10 double-exported assets and drop the dead system qrc - #319
Open
gmmcosta15 wants to merge 1 commit into
Open
chore(ui): dedupe 10 double-exported assets and drop the dead system qrc#319gmmcosta15 wants to merge 1 commit into
gmmcosta15 wants to merge 1 commit into
Conversation
gmmcosta15
added
UI/UX
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code refactor
Remove 10 assets exported by two
.qrcfiles under two keys.Delete
system_resources.qrcand its blob, now fully redundant.Repoint
mainWindow,basicFilamentPanel,controlStackedWidgetat the surviving keys.Net 2156 lines removed.
Motivation
Two keys for identical bytes means the asset ships twice and caches twice at runtime.
Tests
make checkgreen.Screenshots
Pending on-device check: filament PLA/PETG/ABS buttons and the control-page fans button changed key.