feat(pixmap): add BlocksPixmap registry and Icon key enum - #323
Open
gmmcosta15 wants to merge 1 commit into
Open
feat(pixmap): add BlocksPixmap registry and Icon key enum#323gmmcosta15 wants to merge 1 commit into
gmmcosta15 wants to merge 1 commit into
Conversation
gmmcosta15
added
enhancement
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature
Icon, aStrEnumwith one member per resource key the handwritten panels draw.Icon.wifi(bars, protected), clamped to the 0..4 assets that exist.BlocksPixmap.icon(), a sharedQIconper path.BlocksPixmap.get(icon, size), a cached raster, 128x128 by default.BlocksPixmap.source(icon), the intrinsic-size pixmap, for full-bleed art only.BlocksPixmap.clear(), called fromon_quitwhileqAppis alive.Bounded cache: on overflow the oldest half is dropped.
No caller converted here; module and tests only.
Motivation
Each panel built its own pixmap from a raw literal, so every icon was rasterized once per widget: 273.0 MiB intrinsic against 16.1 MiB for the same set at 64px on the RF50. Two
QIconobjects over one path do not share a render cache, so the registry holds theQIcon. Eviction is safe because a widget keeps its own reference; the worst case is a duplicate, never a null.Tests
make checkgreen; unit tests for the enum, cache, wifi clamp and eviction. All 83 keys are:/literals, so the PR 2 guard proves they resolve.