refactor(pixmap): route all panel icons through BlocksPixmap - #325
Open
gmmcosta15 wants to merge 2 commits into
Open
refactor(pixmap): route all panel icons through BlocksPixmap#325gmmcosta15 wants to merge 2 commits into
gmmcosta15 wants to merge 2 commits into
Conversation
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code refactor
Convert every remaining handwritten panel and widget.
Use
source()at the 3 full-bleed sites: slider background, babystep graphic, probe helper graphic.Add stylesheet
url(:/...)scanning to the resource guard.Net 116 lines removed across 39 files.
Motivation
Completes the stack: one object owns every pixmap, no handwritten panel holds a raw literal.
drawPixmapclips rather than stretches when the source rect exceeds the pixmap, so full-bleed art needssource(), not a 128x128 raster.The guard could not match
url(:/...), which has no quote next to the:. 17 such sites across 11 panels were invisible to it and only looked covered because the same keys appear quoted elsewhere.Generated UI modules are out of scope;
controlStackedWidget_ui.pyis hand-edited and must not be regenerated.Tests
make checkgreen (pylint 8.27/10, unchanged);docstr-coverage80.3%.Screenshots
Pre-existing and unchanged from
dev: the babystep/probe-helper graphic is a 346x276 asset in a 121px label withsetScaledContents(False), so it is vertically centre-cropped.Future work